linux-kernel - [RFC PATCH] uapi: move struct reiserfs_security_handle out from linux/reiserfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170228005328.GA27363@altlinux.org>
Date:   Tue, 28 Feb 2017 03:53:28 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Al Viro <viro@...iv.linux.org.uk>, Jeff Mahoney <jeffm@...e.com>
Cc:     reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RFC PATCH] uapi: move struct reiserfs_security_handle out from linux/reiserfs_xattr.h

As there seems to be no way struct reiserfs_security_handle could be
passed between the kernel and userspace, move its definition from the
UAPI header to a private header fs/reiserfs/xattr.h which is the only
file in the tree that includes linux/reiserfs_xattr.h.

This also fixes the following linux/reiserfs_xattr.h userspace
compilation error:

/usr/include/linux/reiserfs_xattr.h:21:2: error: unknown type name 'size_t'
  size_t length;

Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
---
Perhaps the whole file could be moved out from the UAPI.
I'm not sure about that, though.

 fs/reiserfs/xattr.h                 | 6 ++++++
 include/uapi/linux/reiserfs_xattr.h | 6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/reiserfs/xattr.h b/fs/reiserfs/xattr.h
index 613ff5a..1ae77ed 100644
--- a/fs/reiserfs/xattr.h
+++ b/fs/reiserfs/xattr.h
@@ -4,6 +4,12 @@
 #include <linux/rwsem.h>
 #include <linux/xattr.h>

+struct reiserfs_security_handle {
+	const char *name;
+	void *value;
+	size_t length;
+};
+
 struct inode;
 struct dentry;
 struct iattr;
diff --git a/include/uapi/linux/reiserfs_xattr.h b/include/uapi/linux/reiserfs_xattr.h
index 38fdd64..e07f4c7 100644
--- a/include/uapi/linux/reiserfs_xattr.h
+++ b/include/uapi/linux/reiserfs_xattr.h
@@ -15,10 +15,4 @@ struct reiserfs_xattr_header {
 	__le32 h_hash;		/* hash of the value */
 };

-struct reiserfs_security_handle {
-	const char *name;
-	void *value;
-	size_t length;
-};
-
 #endif  /*  _LINUX_REISERFS_XATTR_H  */
-- 
ldv