lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Feb 2017 09:01:43 +0000 From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com> To: Tomasz Figa <tomasz.figa@...il.com> CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>, Krzysztof Kozlowski <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, <patches@...nsource.wolfsonmicro.com> Subject: Re: [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range On Mon, Feb 27, 2017 at 11:13:59AM +0900, Tomasz Figa wrote: > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > > index ddc8d6b..864d8b4d 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > > @@ -882,7 +882,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev, > > pin_bank->grange.id = bank; > > pin_bank->grange.pin_base = drvdata->pin_base > > + pin_bank->pin_base; > > - pin_bank->grange.base = pin_bank->gpio_chip.base; > > + pin_bank->grange.base = pin_bank->grange.pin_base; > > If we are not reading the base from the GPIO bank anymore, maybe it > could make sense to actually make samsung_gpiolib_register() use > bank->grange.base as gc->base? This way we would avoid explicitly > numbering two times. > Yeah no problem I can respin with that included. Thanks, Charles
Powered by blists - more mailing lists