linux-kernel - Re: [PATCH 1/4] v4l2: device_register_subdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228091708.GA5214@amd>
Date:   Tue, 28 Feb 2017 10:17:08 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sakari Ailus <sakari.ailus@....fi>
Cc:     sre@...nel.org, pali.rohar@...il.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, laurent.pinchart@...asonboard.com,
        mchehab@...nel.org, ivo.g.dimitrov.75@...il.com
Subject: Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling
 multiple times

Hi!

> Please find my comments below.

Thanks for quick review, will fix.

> >  		switch (vfwn.base.port) {
> >  		case ISP_OF_PHY_CSIPHY1:
> > -			buscfg->interface = ISP_INTERFACE_CSI2C_PHY1;
> > +			if (csi1)
> 
> You could compare vfwn.bus_type == V4L2_MBUS_CSI2 for this. But if you
> choose the local variable, please make it bool instead.

I prefer variable, will switch to bool.

> > +
> > +			buscfg->bus.ccp2.lanecfg.data[0].pos = 1;
> 
> Shouldn't this be vfwn.bus.mipi_csi1.data_lane ?
> 
> > +			buscfg->bus.ccp2.lanecfg.data[0].pol = 0;
> 
> And this one is vfwn.bus.mipi_csi1.lane_polarity[1] .

Thanks for catching this.

Checkpatch issues will be fixed.

								 Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)