linux-kernel - Re: [PATCH] sched: deadline: Fix confusing comments about selection of top pi-waiter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228111537.GL19665@e106622-lin>
Date:   Tue, 28 Feb 2017 11:15:37 +0000
From:   Juri Lelli <Juri.Lelli@....com>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] sched: deadline: Fix confusing comments about selection
 of top pi-waiter

Hi,

On 22/02/17 20:09, Joel Fernandes wrote:
> This comment in the code is incomplete, and I believe it begs a definition of
> dl_boosted to make sense of the condition that follows. Rewrite the comment and
> also rearrange the condition that follows to reflect the first condition "we
> have a top pi-waiter which is a SCHED_DEADLINE task" in that order. Also fix a
> typo that follows.
> 
> Cc: Juri Lelli <Juri.Lelli@....com>
> Signed-off-by: Joel Fernandes <joelaf@...gle.com>

Looks good to me.

Acked-by: Juri Lelli <juri.lelli@....com>

Thanks,

- Juri