lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 28 Feb 2017 12:43:14 +0100
From:   Geert Uytterhoeven <>
To:     Paul Gortmaker <>
Cc:     "" <>,
        Kostenzer Felix <>,
        Arnd Bergmann <>,
        Andrew Morton <>
Subject: Re: [PATCH akpm v2] lib: test_sort: make it explicitly non-modular

Hi Paul,

On Tue, Jan 24, 2017 at 11:56 PM, Paul Gortmaker
<> wrote:
> The Kconfig currently controlling compilation of this code is:
>      lib/Kconfig.debug:config TEST_SORT
>      lib/Kconfig.debug:      bool "Array-based sort test"
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the code there is no doubt it is builtin-only.
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering becomes slightly earlier when we change it
> to use subsys_initcall as done here.  However, since it is a self
> contained test, this shouldn't be an issue and subsys_initcall
> seems like a better fit for this particular case.
> We also delete the MODULE_LICENSE tag since that information is now
> contained at the top of the file in the comments.

Yeah, MODULE_LICENSE is too easy to grep for... :-(

> Cc: Kostenzer Felix <>
> Cc: Arnd Bergmann <>
> Cc: Andrew Morton <>
> Signed-off-by: Paul Gortmaker <>

Can we please stop doing this?

It's very valuable to have modular tests, so you can run them just by
insmodding the test, instead of needing a separate kernel that runs them
at boot.

Will send a revert + modular enablement...




Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists