linux-kernel - Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2017 11:29:03 +0000
From:   James Hogan <james.hogan@...tec.com>
To:     David Hildenbrand <david@...hat.com>
CC:     Andrew Jones <drjones@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Cornelia Huck <cornelia.huck@...ibm.com>,
        Paul Mackerras <paulus@...abs.org>,
        Christoffer Dall <christoffer.dall@...aro.org>
Subject: Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear

On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
> >> Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> >> ---
> >>  arch/mips/kvm/emulate.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> >> index 552ae2b5e911..70614ca41744 100644
> >> --- a/arch/mips/kvm/emulate.c
> >> +++ b/arch/mips/kvm/emulate.c
> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
> >>  		 * check if any I/O interrupts are pending.
> >>  		 */
> >>  		if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
> >> -			__kvm_request_clear(KVM_REQ_UNHALT, vcpu);
> >>  			vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
> >>  		}
> > 
> > should remove the {} too.
> > 
> 
> With that,
> 
> Reviewed-by: David Hildenbrand <david@...hat.com>

and with that:

Acked-by: James Hogan <james.hogan@...tec.com>

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)