linux-kernel - Re: [PATCH 0/3] lib: add module support to sort tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2017 16:28:51 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] lib: add module support to sort tests

On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> 	Hi Andrew,
> 
> This patch series allows to compile the array-based and linked list
> sort
> test code either to loadable modules, or builtin into the kernel.
> 
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
> 
> Thanks for applying!

FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

On the first glance looks okay to me. I didn't carefully checked code
move (I guess -M -C will not help much, though one can play with numbers
there), so I believe Geert didn't change much there.

> 
> Geert Uytterhoeven (3):
>   Revert "lib/test_sort.c: make it explicitly non-modular"
>   lib: add module support to array-based sort tests
>   lib: add module support to linked list sorting tests
> 
>  lib/Kconfig.debug    |  14 ++---
>  lib/Makefile         |   1 +
>  lib/list_sort.c      | 149 ------------------------------------------
> --------
>  lib/test_list_sort.c | 150
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/test_sort.c      |  11 ++--
>  5 files changed, 164 insertions(+), 161 deletions(-)
>  create mode 100644 lib/test_list_sort.c
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy