linux-kernel - Re: [PATCH v4 2/4] Documentation: devicetree: Add LED subnode binding for MT6323 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170228011549.fqpis445uykyhy7d@rob-hp-laptop>
Date:   Mon, 27 Feb 2017 19:15:49 -0600
From:   Rob Herring <robh@...nel.org>
To:     sean.wang@...iatek.com
Cc:     rpurdie@...ys.net, jacek.anaszewski@...il.com,
        lee.jones@...aro.org, matthias.bgg@...il.com, pavel@....cz,
        mark.rutland@....com, devicetree@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        keyhaede@...il.com
Subject: Re: [PATCH v4 2/4] Documentation: devicetree: Add LED subnode
 binding for MT6323 PMIC

On Sat, Feb 25, 2017 at 02:47:19AM +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> This patch adds documentation for devicetree bindings
> for LED support as the subnode of MT6323 PMIC
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  Documentation/devicetree/bindings/mfd/mt6397.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 949c85f..c568d52 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -34,6 +34,10 @@ Optional subnodes:
>  - clk
>  	Required properties:
>  		- compatible: "mediatek,mt6397-clk"
> +- led

Your example in patch 1 doesn't match. This one is correct.

> +	Required properties:
> +		- compatible: "mediatek,mt6323-led"
> +	see Documentation/devicetree/bindings/leds/leds-mt6323.txt
>  
>  Example:
>  	pwrap: pwrap@...0f000 {
> -- 
> 1.9.1
>