linux-kernel - Re: [PATCH 0/2] key payload access with just rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 17:47:18 -0500 (EST)
From:   Jan Stancek <jstancek@...hat.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
        bcodding@...hat.com, asavkov@...hat.com
Subject: Re: [PATCH 0/2] key payload access with just rcu_read_lock()



----- Original Message -----
> From: "David Howells" <dhowells@...hat.com>
> To: "Jan Stancek" <jstancek@...hat.com>
> Cc: dhowells@...hat.com, linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org, bcodding@...hat.com,
> asavkov@...hat.com
> Sent: Monday, 27 February, 2017 11:04:21 PM
> Subject: Re: [PATCH 0/2] key payload access with just rcu_read_lock()
> 
> Jan Stancek <jstancek@...hat.com> wrote:
> 
> > this is a follow-up for "suspicious RCU usage" warning described
> > in these 2 linux-nfs threads:
> >   http://marc.info/?t=147558830300003&r=1&w=2
> >   http://marc.info/?t=148776770500001&r=1&w=2
> > 
> > Did you have something like in mind?
> 
> How about the attached?  It's similar to what you did, but I made the split
> functions different from the original so that all users have to reconsider
> what they actually want.
> 
> David

Looks like there are still couple users that need updating,
I'm hitting following compilation error:

...
  CC [M]  fs/cifs/connect.o
fs/cifs/connect.c: In function ‘cifs_set_cifscreds’:
fs/cifs/connect.c:2442:2: error: implicit declaration of function ‘user_key_payload’ [-Werror=implicit-function-declaration]
  upayload = user_key_payload(key);
  ^
fs/cifs/connect.c:2442:11: error: assignment makes pointer from integer without a cast [-Werror]
  upayload = user_key_payload(key);
           ^

# grep "user_key_payload(" -r . --include=*.c
./drivers/md/dm-crypt.c:        ukp = user_key_payload(key);
./fs/cifs/connect.c:    upayload = user_key_payload(key);
./fs/crypto/keyinfo.c:  ukp = user_key_payload(keyring_key);
./lib/digsig.c: ukp = user_key_payload(key);

# grep "user_key_payload(" -r . --include=*.h
./fs/ecryptfs/ecryptfs_kernel.h:                return (struct ecryptfs_auth_tok *)user_key_payload(key)->data;

Regards,
Jan