linux-kernel - Re: [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m28toq19h6.fsf@baylibre.com>
Date:   Tue, 28 Feb 2017 10:00:37 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Sekhar Nori <nsekhar@...com>, David Lechner <david@...hnology.com>,
        Michael Turquette <mturquette@...libre.com>,
        Patrick Titiano <ptitiano@...libre.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks

Bartosz Golaszewski <bgolaszewski@...libre.com> writes:

> We currently bail-out after applying a single quirk. We will want
> to reuse the function doing the vpif capture registration so remove
> the break; and continue iterating over the quirk array.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Reviewed-by: Kevin Hilman <khilman@...libre.com>

> ---
>  arch/arm/mach-davinci/pdata-quirks.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
> index 5b57da4..36fb217 100644
> --- a/arch/arm/mach-davinci/pdata-quirks.c
> +++ b/arch/arm/mach-davinci/pdata-quirks.c
> @@ -23,7 +23,6 @@ static void pdata_quirks_check(struct pdata_init *quirks)
>  		if (of_machine_is_compatible(quirks->compatible)) {
>  			if (quirks->fn)
>  				quirks->fn();
> -			break;
>  		}
>  		quirks++;
>  	}