linux-kernel - Re: [PATCH V3 2/3] sched/deadline: Throttle a constrained deadline task activated after the deadline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43aa3b8c-5f5a-50f9-0d3d-aac86c5fcd3f@redhat.com>
Date:   Tue, 28 Feb 2017 19:19:45 +0100
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Juri Lelli <juri.lelli@....com>,
        Tommaso Cucinotta <tommaso.cucinotta@...up.it>,
        Luca Abeni <luca.abeni@...tannapisa.it>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mike Galbraith <efault@....de>,
        Romulo Silva de Oliveira <romulo.deoliveira@...c.br>
Subject: Re: [PATCH V3 2/3] sched/deadline: Throttle a constrained deadline
 task activated after the deadline

On 02/28/2017 11:07 AM, Daniel Bristot de Oliveira wrote:
> +	if (!pi_se->dl_throttled && dl_is_constrained(pi_se))
> +		dl_check_constrained_dl(pi_se);
> +

me--, it should be &p->dl, not pi_se. This is not causing problems in
the test case because pi_se = &p->dl, but this would be a problem if we
were activating the task in a PI case: it would check the pi-waiter, not
the task being awakened (p).

In the dl_check_constrained_dl(), the patch is already avoiding
throttling if the task is "dl_boosted." So it is ready to avoid
throttling the task in the PI control.

Cooking a v4, sorry for the noise.

-- Daniel