linux-kernel - Re: [PATCH v2 3/3] spi: allow registering empty spi_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228182605.GB20776@dtor-ws>
Date:   Tue, 28 Feb 2017 10:26:05 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] spi: allow registering empty spi_board_info lists

On Tue, Feb 28, 2017 at 04:01:46PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 28, 2017 at 6:18 AM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> > Many boards form list of spi_board_info entries depending on config,
> > and it is possible to end up with empty list. Do not report error
> > in such cases.
> 
> If there is an actual case already it would be better to make the
> patch first in the series with Cc: stable@.

arch/blackfin/mach-bf533/boards/ezkit.c: you can get config convoluted
enough so that you'll end up with empty array. But nobody checks the
result of the call, so the failure is not visible. There is no need to
cc stable@ for this.

> 
> FWIW:
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 

Thanks.

-- 
Dmitry