linux-kernel - Re: [PATCH V2 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170228192517.GA22709@kroah.com>
Date:   Tue, 28 Feb 2017 20:25:17 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Derek Robson <robsonde@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        amitoj1606@...il.com, raphael.beamonte@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

On Tue, Feb 28, 2017 at 06:12:35PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
> Version #1 introduced lines over 80.
> This version moves comments to be above the line of code.
> 
> 
>  drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 173 ++++++++++++++++-------------
>  1 file changed, 98 insertions(+), 75 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> index 1102451a733d..d8b443b08bba 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> @@ -150,83 +150,105 @@ uint oid_rt_get_power_mode_hdl(
>  #ifdef _RTL871X_MP_IOCTL_C_ /* CAUTION!!! */
>  /* This ifdef _MUST_ be left in!! */
>  static const struct oid_obj_priv oid_rtl_seg_81_80_00[] = {
> -	{1, oid_null_function},		/*0x00	OID_RT_PRO_RESET_DUT */
> -	{1, oid_rt_pro_set_data_rate_hdl},	/*0x01*/
> -	{1, oid_rt_pro_start_test_hdl}, /*0x02*/
> -	{1, oid_rt_pro_stop_test_hdl},	/*0x03*/
> -	{1, oid_null_function},		/*0x04	OID_RT_PRO_SET_PREAMBLE*/
> -	{1, oid_null_function},		/*0x05	OID_RT_PRO_SET_SCRAMBLER*/
> -	{1, oid_null_function},		/*0x06	OID_RT_PRO_SET_FILTER_BB*/
> -	{1, oid_null_function},		/*0x07
> -					 * OID_RT_PRO_SET_MANUAL_DIVERS_BB
> -					 */
> -	{1, oid_rt_pro_set_channel_direct_call_hdl},	/*0x08*/
> -	{1, oid_null_function},		/*0x09
> -				* OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL
> -				*/
> -	{1, oid_null_function},		/*0x0A
> -				* OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL
> -				*/
> -	{1, oid_rt_pro_set_continuous_tx_hdl},	/*0x0B
> -				* OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL
> -				*/
> -	{1, oid_rt_pro_set_single_carrier_tx_hdl}, /*0x0C
> -				* OID_RT_PRO_SET_SINGLE_CARRIER_TX_CONTINUOUS
> -				*/
> -	{1, oid_null_function},		/*0x0D
> -				* OID_RT_PRO_SET_TX_ANTENNA_BB
> -				*/
> -	{1, oid_rt_pro_set_antenna_bb_hdl},		/*0x0E*/
> -	{1, oid_null_function},		/*0x0F	OID_RT_PRO_SET_CR_SCRAMBLER*/
> -	{1, oid_null_function},		/*0x10	OID_RT_PRO_SET_CR_NEW_FILTER*/
> -	{1, oid_rt_pro_set_tx_power_control_hdl}, /*0x11
> -				* OID_RT_PRO_SET_TX_POWER_CONTROL
> -				*/
> -	{1, oid_null_function},		/*0x12	OID_RT_PRO_SET_CR_TX_CONFIG*/
> -	{1, oid_null_function},		/*0x13
> -					 * OID_RT_PRO_GET_TX_POWER_CONTROL
> -					 */
> -	{1, oid_null_function},		/*0x14
> -					 * OID_RT_PRO_GET_CR_SIGNAL_QUALITY
> -					 */
> -	{1, oid_null_function},		/*0x15	OID_RT_PRO_SET_CR_SETPOINT*/
> -	{1, oid_null_function},		/*0x16	OID_RT_PRO_SET_INTEGRATOR*/
> -	{1, oid_null_function},		/*0x17	OID_RT_PRO_SET_SIGNAL_QUALITY*/
> -	{1, oid_null_function},		/*0x18	OID_RT_PRO_GET_INTEGRATOR*/
> -	{1, oid_null_function},		/*0x19	OID_RT_PRO_GET_SIGNAL_QUALITY*/
> -	{1, oid_null_function},		/*0x1A	OID_RT_PRO_QUERY_EEPROM_TYPE*/
> -	{1, oid_null_function},		/*0x1B	OID_RT_PRO_WRITE_MAC_ADDRESS*/
> -	{1, oid_null_function},		/*0x1C	OID_RT_PRO_READ_MAC_ADDRESS*/
> -	{1, oid_null_function},		/*0x1D	OID_RT_PRO_WRITE_CIS_DATA*/
> -	{1, oid_null_function},		/*0x1E	OID_RT_PRO_READ_CIS_DATA*/
> -	{1, oid_null_function}		/*0x1F	OID_RT_PRO_WRITE_POWER_CONTROL*/
> +	/*0x00	OID_RT_PRO_RESET_DUT */

Please always put a ' ' in the comment after and before the '*'.  This
should look like:
	/* 0x00	OID_RT_PRO_RESET_DUT */

And this:
> +	/*0x04	OID_RT_PRO_SET_PREAMBLE*/

Should look like:
	/* 0x04	OID_RT_PRO_SET_PREAMBLE */

thanks,

greg k-h