linux-kernel - [PATCH -next] watchdog/wm831x: fix build when COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bb4874f-7d0e-225f-3a97-842c2d171c78@infradead.org>
Date:   Tue, 28 Feb 2017 10:31:15 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-watchdog@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Cc:     Wim Van Sebroeck <wim@...ana.be>,
        Guenter Roeck <linux@...ck-us.net>,
        Mark Brown <broonie@...nel.org>,
        patches@...nsource.wolfsonmicro.com
Subject: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled

From: Randy Dunlap <rdunlap@...radead.org>

Fix kconfig dependencies when COMPILE_TEST is enabled so that
interdependent module dependencies are configured as needed.

Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
No other WM831X drivers are enabled.
The problem is in mixing tristate and boolean dependencies.

ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc:	patches@...nsource.wolfsonmicro.com
Cc:	Mark Brown <broonie@...nel.org>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20170228.orig/drivers/watchdog/Kconfig
+++ linux-next-20170228/drivers/watchdog/Kconfig
@@ -176,7 +176,7 @@ config WDAT_WDT

 config WM831X_WATCHDOG
 	tristate "WM831x watchdog"
-	depends on MFD_WM831X || COMPILE_TEST
+	depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
 	select WATCHDOG_CORE
 	help
 	  Support for the watchdog in the WM831x AudioPlus PMICs.  When