linux-kernel - Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3-JwLcQCgfBse0qzHtJcwmOZ9DqLs4B0DjFM45HEYcgQ@mail.gmail.com>
Date:   Tue, 28 Feb 2017 22:48:27 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd

On Tue, Feb 28, 2017 at 10:44 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tue, Feb 28, 2017 at 10:36 PM, Guenter Roeck <linux@...ck-us.net> wrote:
>
>>>  config WM831X_WATCHDOG
>>>       tristate "WM831x watchdog"
>>> -     depends on MFD_WM831X || COMPILE_TEST
>>> +     depends on MFD_WM831X
>>
>> I prefer the fix proposed by Randy:
>>
>> -       depends on MFD_WM831X || COMPILE_TEST
>> +       depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
>>
>
> Agreed, that's better.

Actually I misread. They should be completely equivalent, the part after
the || has no effect here.

     Arnd