linux-kernel - Re: net: GPF in rt6_nexthop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK3qKO6-rr+pNwuk7p--SB9a1sjar00TRN=T_uuh+QZuw@mail.gmail.com>
Date:   Tue, 28 Feb 2017 15:14:40 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: net: GPF in rt6_nexthop_info

On Tue, Feb 28, 2017 at 3:09 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> On 2/28/17 5:10 AM, Eric Dumazet wrote:
>> David, rt->rt6i_idev can be NULL.
>
> Do you know of an example where rt6i_idev can be NULL - besides the
> null_entry rt which is null only because of init order?


I might have been mistaken, but many points in net/ipv6/route.c test
rt->rt6i_idev being NULL or not before dereferencing it.

Maybe other rts (other than null_entry) share this property.