[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0id82bcw-i2dVhu-XsvG2PkBTRw3VtYUJ0KwzMo=YrzhA@mail.gmail.com>
Date: Wed, 1 Mar 2017 00:55:40 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Len Brown <lenb@...nel.org>
Cc: Linux PM <linux-pm@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Len Brown <len.brown@...el.com>,
Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH] intel_idle: stop exposing platform acronyms in sysfs
On Tue, Feb 28, 2017 at 10:32 PM, Len Brown <lenb@...nel.org> wrote:
> From: Len Brown <len.brown@...el.com>
>
> Cosmetic only -- no functional change in this patch.
>
> sysfs before:
>
> state4/desc:MWAIT 0x20
> state4/name:C6-HSW
>
> sysfs after:
>
> state4/desc:MWAIT 0x20
> state4/name:C6
>
> We remove the platform acronyms from the end of the state name
> (-HSW in this case) for three reasonse.
>
> 1. more consistency with acpi_idle, which prints C1, C2, C3 etc.
>
> 2. users know what platform they are on already
> an acronym for the processor code name here
> seems to cause more confusion than clarity.
>
> 3. less clutter in "cpupower monitor" output,
> which truncates the names to 4 columns.
>
> The precise definition of the state continues to be available in "desc".
>
> Cc: Thomas Renninger <trenn@...e.de>
> Reported-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
> Signed-off-by: Len Brown <len.brown@...el.com>
I think I can apply this one right away if you want me to do that.
Thanks,
Rafael
Powered by blists - more mailing lists