linux-kernel - selftests broke upstream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2017 10:24:28 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>
Subject: selftests broke upstream


Hi,

The x86 selftests build broke upstream:

 triton:~/tip/tools/testing/selftests/x86> make
 Makefile:44: warning: overriding recipe for target 'clean'
 ../lib.mk:51: warning: ignoring old recipe for target 'clean'
 gcc -m32 -o /single_step_syscall_32 -O2 -g -std=gnu99 -pthread -Wall  
 single_step_syscall.c -lrt -ldl -lm
 /usr/bin/ld: cannot open output file /single_step_syscall_32: Permission denied
 collect2: error: ld returned 1 exit status
 Makefile:47: recipe for target '/single_step_syscall_32' failed
 make: *** [/single_step_syscall_32] Error 1

It used to be possible to build only the x86 testcases in that directory.

Another problem is that the pkeys testcases are still very noisy:

gcc -m64 -o /home/mingo/tip/tools/testing/selftests/x86/protection_keys_64 -O2 -g -std=gnu99 -pthread -Wall  protection_keys.c -lrt -ldl
In file included from protection_keys.c:45:0:
pkey-helpers.h: In function ‘sigsafe_printf’:
pkey-helpers.h:41:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
   write(1, dprint_in_signal_buffer, len);
   ^
protection_keys.c: In function ‘dumpit’:
protection_keys.c:407:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
   write(1, buf, nr_read);
   ^
gcc -m64 -o /home/mingo/tip/tools/testing/selftests/x86/test_vdso_64 -O2 -g -std=gnu99 -pthread -Wall  test_vdso.c -lrt -ldl
test_vdso.c: In function ‘main’:
test_vdso.c:98:37: warning: ‘node’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (!ret_vsys && (cpu_vsys != cpu || node_vsys != node))
                                     ^
test_vdso.c:78:12: note: ‘node’ was declared here
   unsigned node;
            ^

I thought all this got already fixed?

Thanks,

	Ingo