linux-kernel - Re: [PATCH 1/2] vfs: implement fchmodat2() syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38b0d8a4-a87e-a561-a666-a573dc232108@redhat.com>
Date:   Tue, 28 Feb 2017 12:59:41 -0600
From:   Eric Blake <eblake@...hat.com>
To:     Greg Kurz <groug@...d.org>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] vfs: implement fchmodat2() syscall

On 02/28/2017 12:41 PM, Greg Kurz wrote:

>>> +++ b/include/linux/syscalls.h
>>> @@ -775,6 +775,8 @@ asmlinkage long sys_futimesat(int dfd, const char __user *filename,
>>>  asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode);
>>>  asmlinkage long sys_fchmodat(int dfd, const char __user * filename,
>>>  			     umode_t mode);
>>> +asmlinkage long sys_fchmodat2(int dfd, const char __user *filename,
>>> +			      umode_t mode, int flag);
>>>  asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user,
>>>  			     gid_t group, int flag);  
>>
>> Is the indentation off here?
>>
> 
> This is linux style indent with tabs+spaces. FWIW it is displayed correctly
> in vi and emacs (I've simply copied the sys_fchmodat() declaration).

Sorry for the noise; I see that it is correct now, since fchmodat2 is
one bye longer than fchmodat or fchownat.  Sometimes, I wish I could
convince my mailer to display leading tabs as exactly 8 spaces rather
than to the next 8-space tab stop, so that prefixed characters that
aren't tab-stop aligned don't mess with the actual visual output.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Download attachment "signature.asc" of type "application/pgp-signature" (605 bytes)