linux-kernel - Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170301104919.GL2742@localhost.localdomain>
Date:   Wed, 1 Mar 2017 10:49:19 +0000
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     <linux-watchdog@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ana.be>,
        Guenter Roeck <linux@...ck-us.net>,
        "Mark Brown" <broonie@...nel.org>,
        <patches@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is
 enabled

On Tue, Feb 28, 2017 at 10:31:15AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix kconfig dependencies when COMPILE_TEST is enabled so that
> interdependent module dependencies are configured as needed.
> 
> Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
> No other WM831X drivers are enabled.
> The problem is in mixing tristate and boolean dependencies.
> 
> ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	patches@...nsource.wolfsonmicro.com
> Cc:	Mark Brown <broonie@...nel.org>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles