lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Mar 2017 13:47:53 +0000 From: Matt Redfearn <matt.redfearn@...tec.com> To: "Maciej W. Rozycki" <macro@...tec.com> CC: Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>, Marcin Nowakowski <marcin.nowakowski@...tec.com>, <linux-kernel@...r.kernel.org>, Paul Burton <paul.burton@...tec.com> Subject: Re: [PATCH 1/4] MIPS: Handle non word sized instructions when examining frame Hi Maciej On 28/02/17 20:54, Maciej W. Rozycki wrote: > On Tue, 28 Feb 2017, Matt Redfearn wrote: > >> Since the instruction modifying the stack pointer is usually the first >> in the function, that one is ususally handled correctly. But the > s/ususally/usually/ oops > >> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c >> index 803e255b6fc3..5b1e932ae973 100644 >> --- a/arch/mips/kernel/process.c >> +++ b/arch/mips/kernel/process.c >> @@ -347,6 +347,7 @@ static int get_frame_info(struct mips_frame_info *info) >> union mips_instruction insn, *ip, *ip_end; >> const unsigned int max_insns = 128; >> unsigned int i; >> + unsigned int last_insn_size = 0; > Please keep declarations in the reverse Christmas tree order, i.e. swap > the last two. > > Maciej OK, no problem. Thanks, Matt
Powered by blists - more mailing lists