linux-kernel - Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170301143011.GI6515@twins.programming.kicks-ass.net>
Date:   Wed, 1 Mar 2017 15:30:11 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Taeung Song <treeze.taeung@...il.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Wang Nan <wangnan0@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote:

> > What's the point of source-only? You can't even see what it is that is
> > expensive.
> 
> ???

>From a line like:

		a = b ? ptr->c : 0;

How do you tell what it is that causes the problem, the branch miss or
the pointer deref?

Typically looking at the asm this is fairly clear; even without
recording with more specific events.

> This is to show source code + overhead (for each line).  People can
> see which line of their source is expensive.  I think it's way more
> intuitive for most developers..

And how pray are you going to write better code if you have no clue what
the problem is?

I'm really wondering how you can even think about performance if you're
scared of asm.