linux-kernel - Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3b74939fba413113eef30865bc6f2ba@codeaurora.org>
Date:   Wed, 01 Mar 2017 10:29:13 -0800
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     "Potomski, MichalX" <michalx.potomski@...el.com>,
        "'vinholikatti@...il.com'" <vinholikatti@...il.com>,
        "'jejb@...ux.vnet.ibm.com'" <jejb@...ux.vnet.ibm.com>,
        "'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        "Janca, Grzegorz" <grzegorz.janca@...el.com>,
        "Mielczarek, SzymonX" <szymonx.mielczarek@...el.com>,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

On 2017-02-27 19:24, Martin K. Petersen wrote:
>>>>>> "Michal" == Potomski, MichalX <michalx.potomski@...el.com> writes:
> 
> Michal> Since in UFS 2.1 specification some of the descriptor lengths
> Michal> differs from 2.0 specification and some devices, which are
> Michal> reporting spec version 2.0 have different descriptor lengths we
> Michal> can not rely on hardcoded values taken from 2.0
> Michal> specification. This patch introduces reading these lengths per
> Michal> each device from descriptor headers at probe time to ensure
> Michal> their correctness.
> 
> Subhash: I assume v2 still carries your Reviewed-by:?

Yes, v2 also looks good to me.

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project