linux-kernel - Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170301113750.airgtqq5jivmjuod@sirena.org.uk>
Date:   Wed, 1 Mar 2017 11:37:50 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jeremy Linton <lintonrjeremy@...il.com>
Cc:     puck.chen@...ilicon.com, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads

On Tue, Feb 28, 2017 at 07:07:06PM -0600, Jeremy Linton wrote:
> The hi655x driver is required for mmc/sd functionality on the
> 96boards hikey, and likely other platforms. When built as
> a standalone module it doesn't get automatically loaded because
> it is missing the module probe hooks.

> +static const struct of_device_id hi655x_dt_ids[] = {
> +	{ .compatible = "hisilicon,hi655x-pmic",  },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, hi655x_dt_ids);

This is an MFD subdevice, I'd expect it to instantiate as a platform
device from the MFD - there shouldn't be a compatible string in the DT
and indeed one is not documented (I see something slipped into the
example but it's not in the actual binding).  It's not like this device
can exist independently of the parent device and that compatible string
is not specific enough anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)