linux-kernel - Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170301174004.rakmjjpsq42nbbay@sirena.org.uk>
Date:   Wed, 1 Mar 2017 17:40:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jeremy Linton <lintonrjeremy@...il.com>
Cc:     puck.chen@...ilicon.com, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads

On Wed, Mar 01, 2017 at 10:44:16AM -0600, Jeremy Linton wrote:

> Right, there also appears to be dependency issues. Its like the
> regulator should be pulling in the parent pmic rather than the current

No, why would it do that?  The regulator can't be instantiated without
the parent so it can't do anything until the parent appears.

> situation where the pmic loads, the mmc subsystem loads, but then
> triggers hung task timeouts until the regulator is manually loaded.

If MMC needs a regulator it should be deferring probe until the
regulator appears.

> Worse, because the pmic isn't being held by the regulator you get this
> if the pmic is unloaded.
> 
> [31695.158053] ------------[ cut here ]------------
> [31695.162713] WARNING: CPU: 4 PID: 1729 at
> drivers/regulator/core.c:4136 regulator_unregister+0xfc/0x104

This is nothing to do with the parent, this is telling you that you're
removing a device which is currently in use which is obviously not going
to go well.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)