linux-kernel - Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170301205647.GA21651@kroah.com>
Date:   Wed, 1 Mar 2017 21:56:47 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Avraham Shukron <avraham.shukron@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>, jikos@...nel.org,
        benjamin.tissoires@...hat.com, linux-usb@...r.kernel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

On Wed, Mar 01, 2017 at 09:59:31PM +0200, Avraham Shukron wrote:
> > 
> > This kind of change is definitely not helpful. The original table was
> > Nx16, you converted it to Nx14. Why do you think original table used 16
> > columns?
> > 
> > Regardless, it's a very old driver, just let it be.
> > 
> > Thanks.
> > 
> 
> I can make it Nx8 :)
> 
> Seriously now - I don't understand what is so wrong with checkpatch fixes?
> I'm a new to kernel development, and the natural place to start is to do some
> coding style fixes.

Start doing this in the drivers/staging/ portion of the kernel.  Other
places usually do not want these types of changes for the reasons people
have given you already.

That is what drivers/staging/ is for, to learn the process.  Please
stick to it there.

thanks,

greg k-h