linux-kernel - Re: [PATCH 2/2] mfd: add TI LMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170301004441.GH20572@atomide.com>
Date:   Tue, 28 Feb 2017 16:44:41 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Milo Kim <milo.kim@...com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: add TI LMU driver

* Milo Kim <milo.kim@...com> [170227 22:47]:
> TI LMU (Lighting Management Unit) driver supports lighting devices below.
> 
>   LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697.
> 
> LMU devices have common features.
>   - I2C interface for accessing device registers
>   - Hardware enable pin control
>   - Backlight brightness control
>   - Notifier for hardware fault monitoring
>   - Regulators for LCD display bias
> 
> It contains fault monitor, backlight, LED and regulator driver.
> 
> LMU fault monitor
> -----------------
>   LM3633 and LM3697 provide hardware monitoring feature.
>   It enables open or short circuit detection.
>   After monitoring is done, each device should be re-initialized.
>   Notifier is used for this case.
>   Separate patch for 'ti-lmu-fault-monitor' will be sent later.
> 
> Backlight
> ---------
>   It's handled by TI LMU backlight consolidated driver and
>   chip dependent data. Separate patchset will be sent later.
> 
> LED indicator
> -------------
>   LM3633 has 6 indicator LEDs. Programmable dimming pattern is also
>   supported. Separate patch for 'leds-lm3633' will be sent later.
> 
> Regulator
> ---------
>   LM3631 has 5 regulators for the display bias.
>   LM3632 supports 3 regulators. One consolidated driver enables it.
>   The lm363x regulator driver is already upstreamed.
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Milo Kim <milo.kim@...com>

This works for me on droid 4 with LM3632 using your earlier
"[v2,7/9] backlight: add TI LMU backlight driver" patch at
https://patchwork.kernel.org/patch/7704601/

I had to update the dts file according to the binding and then
enable backlight after booting with:

# echo 180 > /sys/class/backlight/lcd/brightness

So please feel free to add:

Tested-by: Tony Lindgren <tony@...mide.com>