linux-kernel - Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170302022627.GJ13926@pxdev.xzpeter.org>
Date:   Thu, 2 Mar 2017 10:26:27 +0800
From:   Peter Xu <peterx@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Andrew Jones <drjones@...hat.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Cornelia Huck <cornelia.huck@...ibm.com>,
        James Hogan <james.hogan@...tec.com>,
        Paul Mackerras <paulus@...abs.org>,
        Christoffer Dall <christoffer.dall@...aro.org>,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

On Thu, Mar 02, 2017 at 09:15:33AM +0800, Peter Xu wrote:

[...]

> Meanwhile, I think it's still worthwhile to go through the patch even
> it's from cocinelle since sometimes coccinelle might do something that
> we (or only me?) didn't expect. E.g., afaik it cannot handle well with
> over-80-chars lines, so we need to wrap them on our own (I got a patch
> from the author though to fix this, but not yet tested).

Sorry I should definitely mention that that issue only exists in
special conditions, iirc like printf("string1" "string2") and when the
strings are very long, since I believe in most cases coccinelle works
perfectly well. Thanks,

-- peterx