linux-kernel - RE: [PATCH v5 06/13] lockdep: Implement crossrelease feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <004101d2930f$d51a9f90$7f4fdeb0$@lge.com>
Date:   Thu, 2 Mar 2017 13:45:35 +0900
From:   "byungchul.park" <byungchul.park@....com>
To:     "'Matthew Wilcox'" <willy@...radead.org>,
        "'Peter Zijlstra'" <peterz@...radead.org>
Cc:     <mingo@...nel.org>, <tglx@...utronix.de>, <walken@...gle.com>,
        <boqun.feng@...il.com>, <kirill@...temov.name>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <iamjoonsoo.kim@....com>, <akpm@...ux-foundation.org>,
        <npiggin@...il.com>, <kernel-team@....com>
Subject: RE: [PATCH v5 06/13] lockdep: Implement crossrelease feature

> -----Original Message-----
> From: Matthew Wilcox [mailto:willy@...radead.org]
> Sent: Thursday, March 02, 2017 1:20 PM
> To: Peter Zijlstra
> Cc: Byungchul Park; mingo@...nel.org; tglx@...utronix.de;
> walken@...gle.com; boqun.feng@...il.com; kirill@...temov.name; linux-
> kernel@...r.kernel.org; linux-mm@...ck.org; iamjoonsoo.kim@....com;
> akpm@...ux-foundation.org; npiggin@...il.com
> Subject: Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature
> 
> On Tue, Feb 28, 2017 at 07:15:47PM +0100, Peter Zijlstra wrote:
> > (And we should not be returning to userspace with locks held anyway --
> > lockdep already has a check for that).
> 
> Don't we return to userspace with page locks held, eg during async
> directio?

Hello,

I think that the check when returning to user with crosslocks held
should be an exception. Don't you think so?

Thanks,
Byungchul