linux-kernel - Re: [PATCH 2/2] HID: Remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1488437696.2179.3.camel@perches.com>
Date:   Wed, 01 Mar 2017 22:54:56 -0800
From:   Joe Perches <joe@...ches.com>
To:     Michel Hermier <michel.hermier@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Bruno Prémont <bonbons@...ux-vserver.org>,
        Stefan Achatz <erazor_de@...rs.sourceforge.net>,
        Jonathan Cameron <jic23@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: Remove unnecessary OOM messages

On Thu, 2017-03-02 at 07:51 +0100, Michel Hermier wrote:
> Le 01/03/2017 à 20:19, Joe Perches a écrit :
> > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
[]
> > @@ -224,7 +224,6 @@ static int asus_start_multitouch(struct hid_device *hdev)
> >   
> >   	if (!dmabuf) {
> >   		ret = -ENOMEM;
> > -		hid_err(hdev, "Asus failed to alloc dma buf: %d\n", ret);
> >   		return ret;
> >   	}
> 
> Trivial set and return value missed.

You're welcome to submit a follow-on patch.

The compiler should produce the same code
in any case.