linux-kernel - Re: [RFC 03/11] mm: remove SWAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Mar 2017 15:34:45 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Minchan Kim'" <minchan@...nel.org>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>
Cc:     <kernel-team@....com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>,
        "'Johannes Weiner'" <hannes@...xchg.org>,
        "'Michal Hocko'" <mhocko@...e.com>,
        "'Shaohua Li'" <shli@...nel.org>
Subject: Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu


On March 02, 2017 2:39 PM Minchan Kim wrote: 
> @@ -1424,7 +1424,8 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>  			} else if (!PageSwapBacked(page)) {
>  				/* dirty MADV_FREE page */

Nit: enrich the comment please.
>  				set_pte_at(mm, address, pvmw.pte, pteval);
> -				ret = SWAP_DIRTY;
> +				SetPageSwapBacked(page);
> +				ret = SWAP_FAIL;
>  				page_vma_mapped_walk_done(&pvmw);
>  				break;
>  			}