linux-kernel - Re: [PATCH] cpufreq: mt8173: Add support for MT8176 and MT817x compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170302103957.GB13760@vireshk-i7>
Date:   Thu, 2 Mar 2017 16:09:57 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Daniel Kurtz <djkurtz@...omium.org>
Cc:     Yidi Lin <yidi.lin@...iatek.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "open list:CPU FREQUENCY DRIVERS" <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] cpufreq: mt8173: Add support for MT8176 and MT817x
 compatibles

On 02-03-17, 18:36, Daniel Kurtz wrote:
> The Mediatek MT8173 is just on of several SOCs from the same MT817x family,

s/on/one

> including the 6-core (4-little/2-big) MT8176.
> 
> The mt8173-cpufreq driver supports all of these SOCs, however, machines
> using them may use a different machine compatible.
> 
> Since this driver checks explicitly for the machine compatible string, add
> support for the whole family.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
> ---
> This patch is based on the compatibles added by the MT8176 series:
> 
>  https://patchwork.kernel.org/patch/9573209/
>  https://patchwork.kernel.org/patch/9573213/
> 
>  drivers/cpufreq/mt8173-cpufreq.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index ab25b1235a5e..07f7aac56f31 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -573,13 +573,34 @@ static struct platform_driver mt8173_cpufreq_platdrv = {
>  	.probe		= mt8173_cpufreq_probe,
>  };
>  
> +/* List of machine compatible strings supported by this driver */
> +static const char *mt8173_cpufreq_machines[] = {
> +	"mediatek,mt817x",
> +	"mediatek,mt8173",
> +	"mediatek,mt8176",
> +};
> +
> +static int mt8173_cpufreq_is_compatible(void)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(mt8173_cpufreq_machines); i++)
> +		if (of_machine_is_compatible(mt8173_cpufreq_machines[i]))
> +			return 0;
> +
> +	return -ENODEV;
> +}
> +
>  static int mt8173_cpufreq_driver_init(void)
>  {
>  	struct platform_device *pdev;
>  	int err;
>  
> -	if (!of_machine_is_compatible("mediatek,mt8173"))
> -		return -ENODEV;
> +	err = mt8173_cpufreq_is_compatible();

Use of_match_node() instead (hint: cpufreq-dt-platdev.c)

> +	if (err) {
> +		pr_err("Machine is not compatible with 'mediatek,mt8173'\n");
> +		return err;
> +	}
>  
>  	err = platform_driver_register(&mt8173_cpufreq_platdrv);
>  	if (err)

-- 
viresh