linux-kernel - Re: [Outreachy kernel] [PATCH] staging: speakup: Alignment match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1703021131220.3414@hadrien>
Date:   Thu, 2 Mar 2017 11:32:56 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
cc:     w.d.hubbs@...il.com, Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: speakup: Alignment match
 open parenthesis



On Thu, 2 Mar 2017, Arushi Singhal wrote:

> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>  drivers/staging/speakup/i18n.c     |  2 +-
>  drivers/staging/speakup/kobjects.c | 38 +++++++++++++++++++-------------------
>  2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index 11f1418b4006..ac1ebead3c3f 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -607,7 +607,7 @@ void spk_reset_msg_group(struct msg_group_t *group)
>  void spk_initialize_msgs(void)
>  {
>  	memcpy(speakup_msgs, speakup_default_msgs,
> -		sizeof(speakup_default_msgs));
> +	       sizeof(speakup_default_msgs));
>  }
>
>  /* Free user-supplied strings when module is unloaded: */
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index fdd6e4b33951..61656c7c2dc9 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -79,7 +79,7 @@ static ssize_t chars_chartab_show(struct kobject *kobj,
>   * character descriptions or chartab entries.
>   */
>  static void report_char_chartab_status(int reset, int received, int used,
> -	int rejected, int do_characters)
> +					int rejected, int do_characters)
>  {
>  	static char const *object_type[] = {
>  		"character class entries",
> @@ -92,7 +92,7 @@ static void report_char_chartab_status(int reset, int received, int used,
>  		pr_info("%s reset to defaults\n", object_type[do_characters]);
>  	} else if (received) {
>  		len = snprintf(buf, sizeof(buf),
> -				" updated %d of %d %s\n",
> +			       " updated %d of %d %s\n",
>  				used, received, object_type[do_characters]);

This line should be lined up too.

julia