linux-kernel - Re: [PATCH v2] tpm: Apply a sane minimum adapterlimit value for retransmission.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 01:27:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Peter Huewe <peterhuewe@....de>, wsa@...-dreams.de,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        Bryan Freed <bfreed@...omium.org>
Subject: Re: [PATCH v2] tpm: Apply a sane minimum adapterlimit value for
 retransmission.

On Wed, Mar 01, 2017 at 04:36:17PM +0100, Enric Balletbo i Serra wrote:
> From: Bryan Freed <bfreed@...omium.org>
> 
> When the I2C Infineon part is attached to an I2C adapter that imposes
> a size limitation, large requests will fail with -EOPNOTSUPP. Retry
> them with a sane minimum size without re-issuing the 0x05 command
> as this appears to occasionally put the TPM in a bad state.
> 
> Signed-off-by: Bryan Freed <bfreed@...omium.org>
> [rework the patch to adapt to the feedback received]
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> This is a reworked version of the original patch based on the
> suggestion made by Wolfram Sang to simply fall back to a sane minimum
> when the maximum fails.

Hi Enric

Maybe you should remember that you need to use smaller transfers? If
you don't remember, but use the full size message every time and only
drop back on error, the i2c core is going to log rate limited
messages. By remembering, there will only be one such message in the
log.

	  Andrew