linux-kernel - Re: [PATCH 0/3] powerpc/mm: page fault handler cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 13:30:38 +0100
From:   Laurent Dufour <ldufour@...ux.vnet.ibm.com>
To:     mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        aneesh.kumar@...ux.vnet.ibm.com, bsingharora@...il.com,
        npiggin@...il.com
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] powerpc/mm: page fault handler cleaning

Kindly ping...

On 14/02/2017 17:45, Laurent Dufour wrote:
> This series attempts to clean the page fault handler in the way it has
> been done previously for the x86 architecture [1].
> 
> The goal is to manage the mmap_sem earlier and only in
> do_page_fault(). This done by handling the retry case earlier, before
> handling the error case.  This way the semaphore can be released
> earlier and the error path processed without holding it.
> 
> The first patch is just moving a unlock to the caller of the service,
> which as no functional impact.
> 
> The second patch is handling the retry case earlier in
> do_page_fault(). This is where most the change are done, but I was
> conservative here, not changing the use of mm_fault_error() in the
> case of the second retry. It may be smarter to handle that case
> separately but this may create duplicate code.
> 
> The last patch is moving up semaphore releasing from mm_fault_error()
> to do_page_fault().
> 
> [1] see commits from Linus Torvalds
>  26178ec11ef3 ("x86: mm: consolidate VM_FAULT_RETRY handling")
>  7fb08eca4527 ("x86: mm: move mmap_sem unlock from mm_fault_error() to
> caller")
> 
> Laurent Dufour (3):
>   powerpc/mm: move mmap_sem unlock up from do_sigbus
>   powerpc/mm: handle VM_FAULT_RETRY earlier
>   powerpc/mm: move mmap_sem unlocking in do_page_fault()
> 
>  arch/powerpc/mm/fault.c | 82 ++++++++++++++++++++++++-------------------------
>  1 file changed, 40 insertions(+), 42 deletions(-)
>