linux-kernel - RE: [PATCH] Drivers: hv: util: move waiting for release to hv_utils

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR03MB266975E97D6A4644E1E49026BF280@MWHPR03MB2669.namprd03.prod.outlook.com>
Date:   Thu, 2 Mar 2017 10:06:13 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "KY Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Alex Ng (LIS)" <alexng@...rosoft.com>
Subject: RE: [PATCH] Drivers: hv: util: move waiting for release to
 hv_utils_transport itself

> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Thursday, March 2, 2017 17:48
> To: devel@...uxdriverproject.org
> Cc: linux-kernel@...r.kernel.org; KY Srinivasan <kys@...rosoft.com>; Haiyang
> Zhang <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; Dexuan Cui <decui@...rosoft.com>; Alex Ng (LIS)
> <alexng@...rosoft.com>
> Subject: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport
> itself
> 
> Waiting for release_event in all three drivers introduced issues on release
> as on_reset() hook is not always called. E.g. if the device was never
> opened we will never get the completion.
> 
> Move the waiting code to hvutil_transport_destroy() and make sure it is
> only called when the device is open. hvt->lock serialization should
> guarantee the absence of races.
> 
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue")
> Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue")
> Reported-by: Dexuan Cui <decui@...rosoft.com>
> Tested-by: Dexuan Cui <decui@...rosoft.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Acked-by: Dexuan Cui <decui@...rosoft.com>