linux-kernel - Re: [RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeb4f4b8-5d0a-f8bc-55da-f8e407f3ea8e@linux.intel.com>
Date:   Thu, 2 Mar 2017 15:40:56 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>, wsa@...-dreams.de,
        robh+dt@...nel.org, mark.rutland@....com,
        andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [RESEND PATCH v6 2/6] i2c: designware: refactoring of the
 i2c-designware

On 03/01/17 17:59, Luis Oliveira wrote:
> - Factor out all _master() part of code from i2c-designware-core
>   and i2c-designware-platdrv to separate functions.
> - Standardize all code related with MASTER mode.
> - I have to take off DW_IC_INTR_TX_EMPTY from DW_IC_INTR_DEFAULT_MASK
>   because it is master specific.
>
> The purpose of this is to prepare the controller to have is I2C MASTER
> flow in a separate driver. To do this first all the
> functions/definitions related to the MASTER flow were identified.
>
> Signed-off-by: Luis Oliveira <lolivei@...opsys.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> V5->v6
> - Removed the __func__ of dev_dbg prints
> - Fix i2c_dw_configure_master() to accept dw_i2c_dev *
>
>  drivers/i2c/busses/i2c-designware-core.c    | 56 +++++++++++++++++------------
>  drivers/i2c/busses/i2c-designware-platdrv.c | 31 +++++++++-------
>  2 files changed, 52 insertions(+), 35 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>