linux-kernel - Re: [PATCH] scsi: qedi: fix build error without DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 15:54:49 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     QLogic-Storage-Upstream@...ium.com,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Saurav Kashyap <saurav.kashyap@...ium.com>,
        Nilesh Javali <nilesh.javali@...ium.com>,
        Chad Dupuis <chad.dupuis@...ium.com>,
        Manish Rangankar <manish.rangankar@...ium.com>,
        Adheer Chandravanshi <adheer.chandravanshi@...gic.com>,
        Arun Easi <arun.easi@...ium.com>,
        Hannes Reinecke <hare@...e.de>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        linux-scsi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qedi: fix build error without DEBUG_FS

On Thu, Mar 2, 2017 at 1:10 PM, Arnd Bergmann <arnd@...db.de> wrote:

>
> -       QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "do_not_recover=%d\n",
> -                 do_not_recover);
> +       QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "qedi_do_not_recover=%d\n",
> +                 qedi_do_not_recover);

> -       QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "do_not_recover=%d\n",
> -                 do_not_recover);
> +       QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "qedi_do_not_recover=%d\n",
> +                 qedi_do_not_recover);
>         return 0;
>  }

> -       { "do_not_recover", qedi_dbg_do_not_recover_ops},
> +       { "qedi_do_not_recover", qedi_dbg_do_not_recover_ops},
>         { "io_trace", NULL },
>         { NULL, NULL }

>
> -       cnt = sprintf(buffer, "do_not_recover=%d\n", do_not_recover);
> +       cnt = sprintf(buffer, "qedi_do_not_recover=%d\n", qedi_do_not_recover);
>         cnt = min_t(int, count, cnt - *ppos);

I just noticed that my search&replace went a little too far, I should not have
touched the instances within strings. Will resend.

     Arnd