linux-kernel - Re: [PATCH] staging: speakup: replace simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170302151712.o7tza5lt3uuoe7av@var.youpi.perso.aquilenet.fr>
Date:   Thu, 2 Mar 2017 16:17:12 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Marcin Ciupak <marcin.s.ciupak@...il.com>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtou8

Marcin Ciupak, on jeu. 02 mars 2017 15:28:23 +0100, wrote:
> -	int val;
> +	int ret;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
> +	ret = kstrtou8(skip_spaces(start), 10, dest);

This is not the same, you need to have start properly move, since it's
used below:

>  	if (*start == ',')
>  		start++;
> -	*dest = (u_char)val;
>  	return start;

Samuel