linux-kernel - Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 16:34:00 +0100
From:   Auger Eric <eric.auger@...hat.com>
To:     Marc Zyngier <marc.zyngier@....com>,
        Mian Yousaf Kaukab <yousaf.kaukab@...e.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        alex.williamson@...hat.com
Cc:     will.deacon@....com
Subject: Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap

Hi,

On 02/03/2017 16:19, Marc Zyngier wrote:
> On 02/03/17 15:11, Mian Yousaf Kaukab wrote:
>> Fix following build error for s390:
>> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
>> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
>>
>> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@...e.com>
>> ---
>> History:
>> v1:
>>  -Return false instead of true as suggested by Marc and Eric.
>>  -Drop 2/2
>>
>>  include/linux/irqdomain.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
>> index 188eced6813e..9f3616085423 100644
>> --- a/include/linux/irqdomain.h
>> +++ b/include/linux/irqdomain.h
>> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>>  {
>>  	return NULL;
>>  }
>> +static inline bool irq_domain_check_msi_remap(void)
>> +{
>> +	return false;
>> +}
>>  #endif /* !CONFIG_IRQ_DOMAIN */
>>  
>>  #endif /* _LINUX_IRQDOMAIN_H */
>>
> 
> Acked-by: Marc Zyngier <marc.zyngier@....com>

Reviewed-by: Eric Auger <eric.auger@...hat.com>

Thanks!

Eric
> 
> I'll queue that now.
> 
> Thanks,
> 
> 	M.
>