linux-kernel - Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170302185946.GL4662@suse.cz>
Date:   Thu, 2 Mar 2017 19:59:46 +0100
From:   David Sterba <dsterba@...e.cz>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        Jeff Mahoney <jeffm@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] btrfs: remove btrfs_err_str function from
 uapi/linux/btrfs.h

On Thu, Mar 02, 2017 at 04:01:17PM +0300, Dmitry V. Levin wrote:
> On Thu, Mar 02, 2017 at 12:42:12PM +0100, David Sterba wrote:
> > On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote:
> > > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote:
> > > > btrfs_err_str function is not called from anywhere and is replicated
> > > > in the userspace headers for btrfs-progs.
> > > > 
> > > > It's removal also fixes the following linux/btrfs.h userspace
> > > > compilation error:
> > > > 
> > > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str':
> > > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function)
> > > >     return NULL;
> > > > 
> > > > Suggested-by: Jeff Mahoney <jeffm@...e.com>
> > > > Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> > > > Reviewed-by: David Sterba <dsterba@...e.com>
> > > > ---
> > > > v3: the patch seems to be lost, resending with updated list of addressees
> > > 
> > > Indeed, I can't find how or where it got lost, sorry. Added to 4.11
> > > again.
> > 
> > So it's because you did not CC linux-btrfs@ , I have the mails in my
> > inbox but haven't found it in the other folder while picking patches.
> 
> Thanks, I though so when Cc'ed linux-btrfs@ the last time.
> 
> Consider updating MAINTAINERS file so that scripts/get_maintainer.pl
> would be able to print the right addressees for btrfs header files:

Good idea.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0001835..04a758f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2905,4 +2905,6 @@ S:	Maintained
>  F:	Documentation/filesystems/btrfs.txt
>  F:	fs/btrfs/
> +F:	include/linux/btrfs*
> +F:	include/uapi/linux/btrfs*
>  
>  BTTV VIDEO4LINUX DRIVER

Please send a proper patch and add

Acked-by: David Sterba <dsterba@...e.com>