linux-kernel - Re: [PATCH] x86/hpet: Prevent might sleep splat on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170302053646.GB398@jagdpanzerIV.localdomain>
Date:   Thu, 2 Mar 2017 14:36:46 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] x86/hpet: Prevent might sleep splat on resume

On (03/01/17 21:10), Thomas Gleixner wrote:
> Sergey reported a might sleep warning triggered from the hpet resume
> path. It's caused by the call to disable_irq() from interrupt disabled
> context.
> 
> The problem with the low level resume code is that it is not accounted as a
> special system_state like we do during the boot process. Calling the same
> code during system boot would not trigger the warning. That's inconsistent
> at best.
> 
> In this particular case it's trivial to replace the disable_irq() with
> disable_hardirq() because this particular code path is solely used from
> system resume and the involved hpet interrupts can never be force threaded.
> 
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: stable@...r.kernel.org


Tested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

thanks!

	-ss