linux-kernel - Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170302210352.GA15572@amd>
Date:   Thu, 2 Mar 2017 22:03:52 +0100
From:   Pavel Machek <pavel@....cz>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Sakari Ailus <sakari.ailus@....fi>, sre@...nel.org,
        pali.rohar@...il.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, mchehab@...nel.org,
        ivo.g.dimitrov.75@...il.com
Subject: Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:
 device_register_subdev_nodes: allow calling multiple times)

Hi!

> > >  static int isp_fwnode_parse(struct device *dev, struct fwnode_handle
> > >  *fwn,
> > >  
> > >  			    struct isp_async_subdev *isd)
> > >  
> > >  {
> > > 
> > > -	struct isp_bus_cfg *buscfg = &isd->bus;
> > > +	struct isp_bus_cfg *buscfg;
> > > 
> > >  	struct v4l2_fwnode_endpoint vfwn;
> > >  	unsigned int i;
> > >  	int ret;
> > >  	bool csi1 = false;
> > > 
> > > +	buscfg = devm_kzalloc(dev, sizeof(*isd->bus), GFP_KERNEL);
> 
> Given that you recently get rid of devm_kzalloc() in the driver, let's not 
> introduce a new one here.

What is wrong with devm_kzalloc()?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)