linux-kernel - Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1488491006.2179.14.camel@perches.com>
Date:   Thu, 02 Mar 2017 13:43:26 -0800
From:   Joe Perches <joe@...ches.com>
To:     simran singhal <singhalsimran0@...il.com>,
        Larry.Finger@...inger.net
Cc:     florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        oleg.drokin@...el.com, marvin24@....de,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on
 void pointer

On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> > 
> 
>   ((T *)x)[...]
> > 
> 
>   ((T*)x)->f
> > 
> 
> - (T*)
>   e
> )

NAK.

Nice, but you still have to verify correctness
before submitting these patches.

> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
[]
> @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
>  		rc = sptlrpc_parse_flavor(val, &flvr);
>  		if (rc) {
>  			CERROR("invalid sptlrpc flavor %s to MGS\n",
> -			       (char *)val);
> +			       val);

Try compiling this.