linux-kernel - Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2017 03:27:22 +0530
From:   SIMRAN SINGHAL <singhalsimran0@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Larry.Finger@...inger.net,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        oleg.drokin@...el.com, marvin24@....de,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove
 unnecessary cast on void pointer

On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall <julia.lawall@...6.fr> wrote:
>> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext)
>>  {
>>       unsigned long irql;
>>       struct recv_reorder_ctrl *preorder_ctrl =
>> -                              (struct recv_reorder_ctrl *)pcontext;
>> +                              pcontext;
>
> Coccinelle doesn't always generate code in the best way.  pcontext can be
> moved up to the previous line in this case.
>
Thanks,
I will send v2.
> julia