linux-kernel - Re: [PATCH v3 5/9] fput: Don't reinvent the wheel but use existing llist API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2017 08:09:11 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     <viro@...iv.linux.org.uk>
CC:     <peterz@...radead.org>, <mingo@...nel.org>, <neilb@...e.de>,
        <nab@...ux-iscsi.org>, <viro@...iv.linux.org.uk>,
        <ying.huang@...el.com>, <shli@...nel.org>,
        <linux-kernel@...r.kernel.org>, <oleg@...hat.com>,
        <kernel-team@....com>
Subject: Re: [PATCH v3 5/9] fput: Don't reinvent the wheel but use existing
 llist API

On Tue, Feb 14, 2017 at 06:44:44PM +0100, Oleg Nesterov wrote:
> On 02/14, Byungchul Park wrote:
> >
> > Although llist provides proper APIs, they are not used. Make them used.
> 
> Reviewed-by: Oleg Nesterov <oleg@...hat.com>

Hello, Al Viro

Sorry for my mistake at the previous spin. I should have been more
careful. Do you think this still has some problems?

> 
> > Signed-off-by: Byungchul Park <byungchul.park@....com>
> > ---
> >  fs/file_table.c | 12 +++++-------
> >  1 file changed, 5 insertions(+), 7 deletions(-)
> > 
> > diff --git a/fs/file_table.c b/fs/file_table.c
> > index 6d982b5..3209da2 100644
> > --- a/fs/file_table.c
> > +++ b/fs/file_table.c
> > @@ -231,12 +231,10 @@ static void __fput(struct file *file)
> >  static void delayed_fput(struct work_struct *unused)
> >  {
> >  	struct llist_node *node = llist_del_all(&delayed_fput_list);
> > -	struct llist_node *next;
> > +	struct file *f, *t;
> >  
> > -	for (; node; node = next) {
> > -		next = llist_next(node);
> > -		__fput(llist_entry(node, struct file, f_u.fu_llist));
> > -	}
> > +	llist_for_each_entry_safe(f, t, node, f_u.fu_llist)
> > +		__fput(f);
> >  }
> >  
> >  static void ____fput(struct callback_head *work)
> > @@ -310,7 +308,7 @@ void put_filp(struct file *file)
> >  }
> >  
> >  void __init files_init(void)
> > -{ 
> > +{
> >  	filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
> >  			SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
> >  	percpu_counter_init(&nr_files, 0, GFP_KERNEL);
> > @@ -329,4 +327,4 @@ void __init files_maxfiles_init(void)
> >  	n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10;
> >  
> >  	files_stat.max_files = max_t(unsigned long, n, NR_FILE);
> > -} 
> > +}
> > -- 
> > 1.9.1
> >