linux-kernel - Re: [RESEND PATCH v2 0/5] Fix the parse_dt of exynos dsi and remove the OF graph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <a9e52516-bb05-7ad3-01d5-da1fe3bc7548@samsung.com>
Date:   Thu, 02 Mar 2017 10:44:19 +0900
From:   Hoegeun Kwon <hoegeun.kwon@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Inki Dae <inki.dae@...sung.com>, jy0922.shim@...sung.com,
        Seung Woo Kim <sw0312.kim@...sung.com>, airlied@...ux.ie,
        kgene@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        catalin.marinas@....com, will.deacon@....com,
        Javier Martinez Canillas <javier@....samsung.com>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Hoegeun Kwon <hoegeun.kwon@...sung.com>
Subject: Re: [RESEND PATCH v2 0/5] Fix the parse_dt of exynos dsi and remove
 the OF graph

On 02/28/2017 06:58 PM, Krzysztof Kozlowski wrote:
> On Tue, Feb 28, 2017 at 10:17 AM, Hoegeun Kwon <hoegeun.kwon@...sung.com> wrote:
>> Hi All,
>>
>> [Resend this v2 patches, because i have missing TO and CC.]
>>
>> The dsi + panel is a parental relationship, so OF grpah is not needed.
>> Therefore, the current dsi_parse_dt function will throw an error,
>> because there is no linked OF graph for case such as fimd + dsi +
>> panel.
>>
>> So the 1/5 patch parse the Pll, burst and esc clock frequency
>> properties in dsi_parse_dt and modified to create a bridge_node only
>> if there is an OF graph associated with dsi.
>>
>> Also fixed the dts, which depend on the 1/5 patch. So removed the
>> ports node and move burst and esc clock frequency properties to the
>> parent (DSI node).
> Discussions in previous thread lead us to bisectability problem.
> Bisectability in regular driver changes is one thing but in case of
> driver + DTS the gap is much bigger. DTS will go through separate tree
> and branches. How do you want to solve the problem?

Sorry for the delay in reply, Mar 1st was the holiday.
I thought of two solutions.

1. squash the patches in a single patch

2. split the dts related patches so that the first part adds the:
+    samsung,burst-clock-frequency = <512000000>;
+    samsung,esc-clock-frequency = <16000000>;

and the second part at the end removes the 'port' node
So it consists of 6 patches in total.

Which do you think is better?
If you have any other ideas, could you tell me?

Best Regards,
Hoegeun

>
> Best regards,
> Krzysztof
>
>
>