linux-kernel - Re: [Outreachy kernel] [PATCH v2 4/5] staging: rts5208: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2017 09:41:07 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     simran singhal <singhalsimran0@...il.com>
cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, oleg.drokin@...el.com,
        marvin24@....de, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 4/5] staging: rts5208: Remove
 unnecessary cast on void pointer

When you send a v2 for a patch in a series, you need to send a v2 for all
of the patches in the series.

julia

On Fri, 3 Mar 2017, simran singhal wrote:

> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
>
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>
>  v2:
>    -Moved buf to the previous line.
>
>  drivers/staging/rts5208/rtsx_transport.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index 2379901..8b57e17 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -766,8 +766,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip, u8 card, void *buf, size_t len,
>  		return -EIO;
>
>  	if (use_sg) {
> -		err = rtsx_transfer_sglist_adma(chip, card,
> -						(struct scatterlist *)buf,
> +		err = rtsx_transfer_sglist_adma(chip, card, buf,
>  						use_sg, dma_dir, timeout);
>  	} else {
>  		err = rtsx_transfer_buf(chip, card, buf, len, dma_dir, timeout);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170303083130.GA25123%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>