lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Mar 2017 18:48:54 +0800 From: Chunyan Zhang <zhang.lyra@...il.com> To: Rob Herring <robh@...nel.org> Cc: Chunyan Zhang <chunyan.zhang@...eadtrum.com>, Mark Rutland <mark.rutland@....com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Arnd Bergmann <arnd@...db.de>, Orson Zhai (翟京) <orson.zhai@...eadtrum.com>, Sudeep Holla <sudeep.holla@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH V3 3/4] dt-bindings: serial: add a new compatible string for SC9860 On 3 March 2017 at 14:21, Rob Herring <robh@...nel.org> wrote: > On Thu, Mar 02, 2017 at 02:22:09PM +0800, Chunyan Zhang wrote: >> SC9860 use the same serial device, so added a new compatible string to >> support SC9860 as well, also added an example of how to describe this >> serial device in DT. >> >> Signed-off-by: Chunyan Zhang <chunyan.zhang@...eadtrum.com> >> --- >> Documentation/devicetree/bindings/serial/sprd-uart.txt | 15 ++++++++++++++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> index 2aff0f2..8bd8144 100644 >> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt >> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> @@ -1,7 +1,20 @@ >> * Spreadtrum serial UART >> >> Required properties: >> -- compatible: must be "sprd,sc9836-uart" >> +- compatible must contain: >> + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs >> + This also can be specific with: >> + * "sprd,sc9860-uart" for SC9860 > > Just say: > > - compatible: must be one of: > "sprd,sc9836-uart" > "sprd,sc9860-uart", "sprd,sc9836-uart" > >> + >> - reg: offset and length of the register set for the device >> - interrupts: exactly one interrupt specifier >> - clocks: phandles to input clocks. >> + >> +Example: >> + uart0: serial@...00000 { >> + compatible = "sprd,sc9860-uart", >> + "sprd,sc9836-uart"; >> + reg = <0x000000 0x100>; > > unit address doesn't match the reg property. OK, I will revise dts file accordingly. Thanks, Chunyan > >> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ext_26m>; >> + }; >> -- >> 2.7.4 >>
Powered by blists - more mailing lists