lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Mar 2017 14:52:11 +0100 From: Alexander Potapenko <glider@...gle.com> To: Andrey Ryabinin <aryabinin@...tuozzo.com> Cc: Andrey Konovalov <andreyknvl@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, kasan-dev <kasan-dev@...glegroups.com>, Linux Memory Management List <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 6/9] kasan: improve slab object description On Fri, Mar 3, 2017 at 2:31 PM, Andrey Ryabinin <aryabinin@...tuozzo.com> wrote: > On 03/02/2017 04:48 PM, Andrey Konovalov wrote: >> Changes slab object description from: >> >> Object at ffff880068388540, in cache kmalloc-128 size: 128 >> >> to: >> >> The buggy address belongs to the object at ffff880068388540 >> which belongs to the cache kmalloc-128 of size 128 >> The buggy address is located 123 bytes inside of >> 128-byte region [ffff880068388540, ffff8800683885c0) >> >> Makes it more explanatory and adds information about relative offset >> of the accessed address to the start of the object. >> > > I don't think that this is an improvement. You replaced one simple line with a huge > and hard to parse text without giving any new/useful information. > Except maybe offset, it useful sometimes, so wouldn't mind adding it to description. Agreed. How about: =========== Access 123 bytes inside of 128-byte region [ffff880068388540, ffff8800683885c0) Object at ffff880068388540 belongs to the cache kmalloc-128 =========== ? > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@...glegroups.com. > To post to this group, send email to kasan-dev@...glegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/db0b6605-32bc-4c7a-0c99-2e60e4bdb11f%40virtuozzo.com. > For more options, visit https://groups.google.com/d/optout. -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
Powered by blists - more mailing lists